Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI - Model Registry API spec #350

Merged
merged 1 commit into from
Sep 6, 2024
Merged

UI - Model Registry API spec #350

merged 1 commit into from
Sep 6, 2024

Conversation

lucferbux
Copy link
Contributor

Description

Add the API module for the UI project with all the endpoints specified in the swagger.
Test coverage for the api module.
No UI changes.

How Has This Been Tested?

Test coverage for the API module.

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages; the author will squash them after approval or in case of manual merges will ask to merge with squash.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

Griffin-Sullivan
Griffin-Sullivan approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@Griffin-Sullivan Griffin-Sullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are all passing

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ederign, Griffin-Sullivan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ederign
Copy link
Member

ederign commented Sep 6, 2024

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 6, 2024
@google-oss-prow google-oss-prow bot merged commit 327e865 into kubeflow:main Sep 6, 2024
15 checks passed
@tarilabs tarilabs mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederign ederign ederign approved these changes

@Griffin-Sullivan Griffin-Sullivan Griffin-Sullivan approved these changes

@alexcreasy alexcreasy Awaiting requested review from alexcreasy

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@ederign ederign

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucferbux @ederign @Griffin-Sullivan